#309 - added better support for Maven Modules#333
Open
dawon wants to merge 1 commit intojenkinsci:masterfrom
Open
#309 - added better support for Maven Modules#333dawon wants to merge 1 commit intojenkinsci:masterfrom
dawon wants to merge 1 commit intojenkinsci:masterfrom
Conversation
Member
|
There are two things. First I recommend to add a copyright header in the source code files and furthermore I would request you to squash your commits and make a commit message like: and most genius would be to add some tests if you can? |
Author
|
I already did remove the output in earlier commit. I will try to squash the commits and the rest things tomorrow. I will also try to create some tests but I don't guarantee anything. |
Author
|
So I did everything except the tests, I have to learn Mockito a bit, so I will maybe add them later when I am able to get them working... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi so I tried adding better Maven Modules support. It is my first Pull Request, so sorry for any problems there might be. In that case, just tell me and I will try to fix it...