4.0.0 Beta 3 #1907
Merged
4.0.0 Beta 3 #1907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: sds100 <[email protected]>
Co-authored-by: sds100 <[email protected]>
Co-authored-by: sds100 <[email protected]>
…access Co-authored-by: sds100 <[email protected]>
- Replace 3 separate ActionIds with single MODIFY_SETTING - Add SettingType enum (SYSTEM, SECURE, GLOBAL) - Update ActionData.ModifySetting to use enum instead of sealed class - Add dropdown for setting type in UI - Default to SYSTEM type (no PRO mode required) - Update all mappers and handlers accordingly Co-authored-by: sds100 <[email protected]>
- Move MODIFY_SETTING to APPS category - Create AndroidSettingsAdapter interface implementing SettingsAdapter - Use SettingsUtils for all setting modifications (no SystemBridge needed) - Remove SystemBridge methods for settings (putSystemSetting, etc) - Add permission checks: WRITE_SETTINGS for System, WRITE_SECURE_SETTINGS for Secure/Global - Remove setting methods from DisplayAdapter Co-authored-by: sds100 <[email protected]>
- Created ChooseSettingViewModel with setting type selection and search - Created ChooseSettingScreen with dropdown for type and searchable list - Added ChooseSetting nav destination - Added string resources for choosesetting screen - Screen shows all available settings with current values - User can select from existing settings or enter custom key Next: Wire up navigation in CreateActionDelegate Co-authored-by: sds100 <[email protected]>
…perDropdownMenu - Import SettingType instead of using fully qualified names - Import Json and Serializable for cleaner code - Replace custom dropdown with KeyMapperDropdownMenu in ChooseSettingScreen - Remove unused imports - Update NavDestination to use imported SettingType Co-authored-by: sds100 <[email protected]>
- Consolidate modify methods into single modifySetting(settingType, key, value) method - Import SettingType instead of using fully qualified name - Replace custom dropdown with KeyMapperDropdownMenu - Add onChooseSetting callback and Button to navigate to ChooseSettingScreen - Update PerformActionsUseCase to use new unified method - Add onChooseSettingClick method to CreateActionDelegate for navigation Co-authored-by: sds100 <[email protected]>
…rrorSnapshot - Refactored getKeys methods into single getAll(settingType) returning Map<String, String?> - Consolidated getValue methods into single getValue(settingType, key) method - Updated ChooseSettingViewModel to use new unified methods - Imported SettingType in ActionErrorSnapshot instead of using fully qualified name - Simplified interface with only 3 methods: getAll, getValue, modifySetting Co-authored-by: sds100 <[email protected]>
- Added CREATE_NOTIFICATION to ActionId enum - Added CreateNotification data class to ActionData with title, text, and optional timeout - Added CHANNEL_CUSTOM_NOTIFICATIONS channel in NotificationController - Added POST_NOTIFICATIONS permission requirement in ActionUtils - Implemented notification creation in PerformActionsUseCase - Added entity mapping in ActionDataEntityMapper - Added string resources for the action - Added notification extras constants in ActionEntity Co-authored-by: sds100 <[email protected]>
- Created ConfigCreateNotificationViewModel for managing notification state - Created CreateNotificationActionScreen with title, text, and timeout inputs - Added navigation support via NavDestination.ConfigCreateNotification - Integrated configuration screen into BaseMainNavHost - Added string resources for configuration UI labels - Marked CreateNotification action as editable - Configured timeout slider with 5-300 second range Co-authored-by: sds100 <[email protected]>
- Improved notification ID generation to avoid collisions using timestamp + hash - Added validation feedback with error messages and disabled Done button - Extracted magic numbers to constants (MIN/MAX/STEP timeout values) - Added supportingText for empty field errors in UI Co-authored-by: sds100 <[email protected]>
- Added validation for entity.data to ensure text is not blank - Fixed notification ID generation to avoid integer overflow - Use Long arithmetic and convert to absolute value to ensure positive IDs Co-authored-by: sds100 <[email protected]>
Co-authored-by: jambl3r <[email protected]>
Co-authored-by: jambl3r <[email protected]>
Co-authored-by: jambl3r <[email protected]>
Co-authored-by: jambl3r <[email protected]>
Co-authored-by: jambl3r <[email protected]>
…e comments Co-authored-by: jambl3r <[email protected]>
- Use action.hashCode() for notification ID as requested - Rename ConfigCreateNotification to ConfigNotificationAction Co-authored-by: sds100 <[email protected]>
…ings-permission Add action to modify Android system settings via key mappings
…ss debugging because some devices show a dialog that will be auto dismissed resulting in wireless ADB being immediately disabled. E.g OnePlus 6T Oxygen OS 11
…er' after starting pro mode
…Xiaomi devices due to a bug they introduced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.