Remove use of deprecated urllib3 functionality#2497
Remove use of deprecated urllib3 functionality#2497stephenfin wants to merge 3 commits intokubernetes-client:release-34.0from
Conversation
…Error:" This reverts commit f9c38c5.
…the upgrade to latest OpenAPI Generator (>6.4.0)" This reverts commit 647d5d1. This was patching the wrong thing.
The Response.getheaders() and Response.getheader() methods were deprecated in urllib3 2.0. They were briefly removed in 2.6.0 [1] before being re-added in 2.6.1 [2], but they will eventually be removed entirely. Carry a patch to address this until the generator is updated accordingly. [1] https://urllib3.readthedocs.io/en/stable/changelog.html#id4 [2] https://urllib3.readthedocs.io/en/stable/changelog.html#id3 Signed-off-by: Stephen Finucane <[email protected]>
k8s-ci-robot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: stephenfin The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/L
|
/close I think we'd be better off working bumping the |
|
@stephenfin: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 participants
What type of PR is this?
/kind feature
What this PR does / why we need it:
Remove use of deprecated urllib3 functionality. As noted in the commit message, this functionality was briefly removed in 2.6.0 but later re-added in 2.6.1. Ultimately, we should fix this by bumping the codegenerator version used here but that's a much larger change that should be tackled separately.
/assign @yliaog
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This is an alternative to #2479.
Does this PR introduce a user-facing change?
(Technically we've deprecated a method but we won't remove this).
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: