Skip to content

Conversation

@YASHMAHAKAL
Copy link
Contributor

Description

Fixed the endpointslices resource API group in the RBAC documentation.

The endpointslices resource was incorrectly shown in the core API group
(apiGroups: [""]) along with services and pods in the "Aggregated
ClusterRoles" example. EndpointSlices actually belong to the
discovery.k8s.io API group.

This PR corrects the example by splitting the rules into two separate entries:

  • Core API group (apiGroups: [""]) for services and pods
  • Discovery API group (apiGroups: ["discovery.k8s.io"]) for endpointslices

This ensures the documentation provides accurate and working RBAC examples.

Issue

Closes: #53857

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jan 1, 2026
@k8s-ci-robot
Copy link
Contributor

Welcome @YASHMAHAKAL!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 1, 2026
@netlify
Copy link

netlify bot commented Jan 1, 2026

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit bf39a96
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/695d430403d2e3000895ae66
😎 Deploy Preview https://deploy-preview-53880--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

# the rules below will be added to the "monitoring" ClusterRole.
rules:
- apiGroups: [""]
resources: ["services", "endpointslices", "pods"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like this was caused by a find/replace of endpoints (which is in the core API group so this was correct) with endpointslices

fixing this is fine, but let's also rename the example ClusterRole to monitoring-endpointslices for clarity

Addresses feedback from kubernetes#53857 review

Signed-off-by: YASHMAHAKAL <[email protected]>
@YASHMAHAKAL
Copy link
Contributor Author

Hello @liggitt, i have rename ClusterRole as per your recommendation... Take a look at it !

@liggitt
Copy link
Member

liggitt commented Jan 6, 2026

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 6, 2026
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

DetailsGit tree hash: 11795d3fda1e0997573e9d7abe234d568628a654

Copy link
Contributor

@tengqm tengqm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2026
@k8s-ci-robot k8s-ci-robot merged commit 033b627 into kubernetes:main Jan 7, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improvement for k8s.io/docs/reference/access-authn-authz/rbac/

4 participants