-
Notifications
You must be signed in to change notification settings - Fork 15.2k
Fix endpointslices API group in RBAC documentation #53880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix endpointslices API group in RBAC documentation #53880
Conversation
Signed-off-by: YASHMAHAKAL <[email protected]>
|
Welcome @YASHMAHAKAL! |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
| # the rules below will be added to the "monitoring" ClusterRole. | ||
| rules: | ||
| - apiGroups: [""] | ||
| resources: ["services", "endpointslices", "pods"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks like this was caused by a find/replace of endpoints (which is in the core API group so this was correct) with endpointslices
fixing this is fine, but let's also rename the example ClusterRole to monitoring-endpointslices for clarity
Addresses feedback from kubernetes#53857 review Signed-off-by: YASHMAHAKAL <[email protected]>
|
Hello @liggitt, i have rename ClusterRole as per your recommendation... Take a look at it ! |
|
/lgtm |
|
LGTM label has been added. DetailsGit tree hash: 11795d3fda1e0997573e9d7abe234d568628a654 |
tengqm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Fixed the
endpointslicesresource API group in the RBAC documentation.The
endpointslicesresource was incorrectly shown in the core API group(
apiGroups: [""]) along withservicesandpodsin the "AggregatedClusterRoles" example. EndpointSlices actually belong to the
discovery.k8s.ioAPI group.This PR corrects the example by splitting the rules into two separate entries:
apiGroups: [""]) forservicesandpodsapiGroups: ["discovery.k8s.io"]) forendpointslicesThis ensures the documentation provides accurate and working RBAC examples.
Issue
Closes: #53857