Bump whoami to v2 #4143
Open
Bump whoami to v2 #4143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tison <[email protected]>
abonander
reviewed
Jan 17, 2026
| } else if let Ok(username) = whoami::username() { | ||
| username | ||
| } else { | ||
| "unknown".to_string() |
Collaborator
There was a problem hiding this comment.
It'd be better to leave this as an empty string; it might be more confusing that it seems to have detected the username unknown, which could feasibly be a real username.
Contributor
Author
There was a problem hiding this comment.
I'm OK to return an empty string.
The original behavior of whoami 1.x is returning "unknown" in this case, BTW.
Contributor
Author
There was a problem hiding this comment.
Suggested change
| "unknown".to_string() | |
| "".to_string() |
Contributor
Author
There was a problem hiding this comment.
Feel free to commit this patch if you are sure. I'm considering that returning an empty string can be a breaking change but you make the call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @abonander