chore: add DataSourceUpdatesSinkV2 support to DataSourceUpdatesImpl #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanderson-ld
commented
Jan 15, 2026
Contributor
Author
There was a problem hiding this comment.
For reviewers: I had accidentally removed these previously.
Member
|
bugbot review |
kinyoklion
reviewed
Jan 15, 2026
| } | ||
|
|
||
| // Calling Apply implies that the data source is now in a valid state. | ||
| updateStatus(State.VALID, null); |
Member
There was a problem hiding this comment.
I might be duplicating this notification, but we can sort the correct layering once we have things connected together.
kinyoklion
approved these changes
Jan 15, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
tanderson-ld
deleted the
ta/SDK-1608/datasource-updates-sinkv2-support
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
SDK-1608
Describe the solution you've provided
Porting related Dotnet sdk changes to Java SDK. Finding new homes for various helper functionality.
Note
Introduces FDv2 transactional update flow and supporting APIs.
TransactionalDataSourceUpdateSinkandDataSourceUpdateSinkV2(status access +updateStatus) for FDv2 data sourcesDataSourceUpdatesImplto implement V2 and handleapply(ChangeSet):TransactionalDataStore.applywith dependency/event handling and status updatesinitand partial to orderedupsertsDataModelDependencies.sortChangesetto order updates by dependencies and data kindSDK_VERSIONWritten by Cursor Bugbot for commit f3b09f5. This will update automatically on new commits. Configure here.