Test that Exec and Query are only called with certain types#351
Open
cbandy wants to merge 1 commit intolib:masterfrom
Open
Test that Exec and Query are only called with certain types#351cbandy wants to merge 1 commit intolib:masterfrom
cbandy wants to merge 1 commit intolib:masterfrom
Conversation
Contributor
|
What was the conclusion with the float32 handling in encode()? Is it dead code? |
Contributor
Author
|
Yes, it's dead. |
Contributor
Author
|
@johto would you like me to include a commit that removes the dead code? |
Contributor
|
@cbandy: Please do. |
Contributor
Author
Contributor
Contributor
Author
|
@johto I think this (or a test like this) is still valuable to include in our suite. What would you like me to do with this PR? |
Contributor
I agree, but I haven't had a chance to review it yet. Sorry about that. |
b7d6287 to
9aeece3
Compare
9aeece3 to
601c35f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
driver.Valueis implemented as aninterface{}, its value can actually be any type. It is the responsibility of thesqlanddriverpackages to emit only a few types for these values.This test ensures those packages are fulfilling their contract in cases we care about.