Fix compilation with WIN32_LEAN_AND_MEAN and use it for hid.c #767
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
The CI build fails in the same place as #765. Local build succeeds with a warning in the SDK. |
Author
|
this change also raises a warning in local copilation which can not be fixed, it is a bug in SDK: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #766
Defining WIN32_LEAN_AND_MEAN removes some rarely-used includes from windows.h, which MSVC uses to speed up compilation. Unfortunately, hidapi_cfgmgr32.h relies on one of those headers. This PR fixes the missing header, as well as makes use of the speed-up define, simultaneously making the build scenarios more uniform regardless of whether the target project uses it or not.