Fix compilation with WIN32_LEAN_AND_MEAN (through UNDEF) #768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youw
reviewed
Dec 31, 2025
| #endif | ||
|
|
||
| #ifdef WIN32_LEAN_AND_MEAN | ||
| /* This define may be set by IDE/project and it breaks compilation */ |
Member
There was a problem hiding this comment.
add details in which cases compilatino is broken (apparently not always)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #766
This version is less complicated and just undefines the thing. The previous PR with a proper solution didn't work well with CI, trying a simpler solution.