fix(sync-k3s-images): skip updating on inconsistent release state #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The k3s release index may be updated before container images are available to use. This change updates the sync-k3s-images recipe to fail if any release images cannot be found. The CI workflow is updated to allow failures. The workflow fails if the sync recipe modifies the cached image digests.
sfleen
approved these changes
Dec 5, 2024
| - uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 | ||
| - uses: ./actions/setup-tools | ||
| - run: just sync-k3s-images | ||
| # The sync may fail when a new K3s version is released. This is expected. |
Contributor
There was a problem hiding this comment.
Should we keep the continue-on-error: true above if this suppresses the error from an updated version?
Member
Author
There was a problem hiding this comment.
Yeah. Since this can fail in general when there are new k3s versions available, we don't want to cancel other workflows just because a new file is generated. It's mostly an advisory check so, when we're doing a new version, for instance, we ensure we've run the sync. This was just a specific weird corner case where the sync would yield an unusable manifest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The k3s release index may be updated before container images are available to use. This change updates the sync-k3s-images recipe to fail if any release images cannot be found. The CI workflow is updated to allow failures. The workflow fails if the sync recipe modifies the cached image digests.