Update LDM python samples to use the new wait_for_debug_client logic #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MEPalma
requested review from
joe4dev
and removed request for
dfangl and
dominikschubert
joe4dev
approved these changes
Jul 18, 2025
Contributor
joe4dev
left a comment
joe4dev
left a comment
There was a problem hiding this comment.
LGTM.
Thank you for pro-actively updating the samples. I tested the base case and the runtime-level debugger attachment is a nice quality of life improvement 🙌
| echo "Invoking the Lambda function, attempt $i." | ||
| AWS_MAX_ATTEMPTS=1 \ | ||
| awslocal lambda invoke \ | ||
| --cli-binary-format raw-in-base64-out \ |
Contributor
There was a problem hiding this comment.
This parameter requires the AWS CLI v2. It fails with the default AWS CLI v1 installation still advertised in awslocal
Contributor
There was a problem hiding this comment.
Adding a comment to clarify this conditional parameter might be a quick fix here (same for all run.sh scripts)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following recent changes to the LDM that allow the debug-enabled Docker container to remain running between invocations, this PR updates the Python-based LDM samples to use a new wait_for_debug_client logic. This update enables the debug client to stay connected and also reconnect multiple times to the container. The samples have been manually validated against the latest LDM changes.
* Unrelated test failures