-
Notifications
You must be signed in to change notification settings - Fork 25
docs: Update LocalStack CLI version in installation guide #365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploying localstack-docs with
|
| Latest commit: |
bc3f07f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://73a9a1bd.localstack-docs.pages.dev |
| Branch Preview URL: | https://docs-fix-missing-backslashes.localstack-docs.pages.dev |
joe4dev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure to remove the hardcoded LOCALSTACK_VERSION before merging.
| or use the following curl command: | ||
|
|
||
| <Code code={`curl --output localstack-cli-${LOCALSTACK_VERSION}-darwin-amd64-onefile.tar.gz \n --location https://github.com/localstack/localstack-cli/releases/download/v${LOCALSTACK_VERSION}/localstack-cli-${LOCALSTACK_VERSION}-darwin-amd64-onefile.tar.gz`} lang="bash" /> | ||
| <Code code={`curl --output ${LOCALSTACK_VERSION}-darwin-amd64-onefile.tar.gz \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joe4dev I've updated the hardcoded version numbers to instead say ${LOCALSTACK_VERSION}.
Let me know if it looks good now 😸
|
Ping @joe4dev 😸 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the macOS installation instructions for the LocalStack CLI to properly format multi-line curl commands with line continuation characters.
Changes:
- Added backslashes for line continuation in the macOS curl command
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <Code code={`curl --output ${LOCALSTACK_VERSION}-darwin-amd64-onefile.tar.gz \ | ||
| --location https://github.com/localstack/localstack-cli/releases/download/${LOCALSTACK_VERSION}/localstack-cli-${LOCALSTACK_VERSION}-darwin-amd64-onefile.tar.gz`} lang="bash" /> |
Copilot
AI
Jan 15, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The output filename is missing the 'localstack-cli-' prefix. It should be 'localstack-cli-${LOCALSTACK_VERSION}-darwin-amd64-onefile.tar.gz' to match the expected filename format used in the download link (line 71) and the tar extraction command (line 80).
| <Code code={`curl --output ${LOCALSTACK_VERSION}-darwin-amd64-onefile.tar.gz \ | |
| --location https://github.com/localstack/localstack-cli/releases/download/${LOCALSTACK_VERSION}/localstack-cli-${LOCALSTACK_VERSION}-darwin-amd64-onefile.tar.gz`} lang="bash" /> | |
| <Code code={`curl --output localstack-cli-${LOCALSTACK_VERSION}-darwin-amd64-onefile.tar.gz \ | |
| --location https://github.com/localstack/localstack-cli/releases/download/v${LOCALSTACK_VERSION}/localstack-cli-${LOCALSTACK_VERSION}-darwin-amd64-onefile.tar.gz`} lang="bash" /> |
|
|
||
| <Code code={`curl --output localstack-cli-${LOCALSTACK_VERSION}-darwin-amd64-onefile.tar.gz \n --location https://github.com/localstack/localstack-cli/releases/download/v${LOCALSTACK_VERSION}/localstack-cli-${LOCALSTACK_VERSION}-darwin-amd64-onefile.tar.gz`} lang="bash" /> | ||
| <Code code={`curl --output ${LOCALSTACK_VERSION}-darwin-amd64-onefile.tar.gz \ | ||
| --location https://github.com/localstack/localstack-cli/releases/download/${LOCALSTACK_VERSION}/localstack-cli-${LOCALSTACK_VERSION}-darwin-amd64-onefile.tar.gz`} lang="bash" /> |
Copilot
AI
Jan 15, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The URL is missing the 'v' prefix before the version variable. It should be 'releases/download/v${LOCALSTACK_VERSION}/' to match the correct URL format used in the download link (line 71) and the Linux section (lines 36, 40).
| --location https://github.com/localstack/localstack-cli/releases/download/${LOCALSTACK_VERSION}/localstack-cli-${LOCALSTACK_VERSION}-darwin-amd64-onefile.tar.gz`} lang="bash" /> | |
| --location https://github.com/localstack/localstack-cli/releases/download/v${LOCALSTACK_VERSION}/localstack-cli-${LOCALSTACK_VERSION}-darwin-amd64-onefile.tar.gz`} lang="bash" /> |
| <Code code={`curl --output ${LOCALSTACK_VERSION}-darwin-amd64-onefile.tar.gz \ | ||
| --location https://github.com/localstack/localstack-cli/releases/download/${LOCALSTACK_VERSION}/localstack-cli-${LOCALSTACK_VERSION}-darwin-amd64-onefile.tar.gz`} lang="bash" /> |
Copilot
AI
Jan 15, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The backslash format should be '\\\n' instead of '\' followed by a newline to maintain consistency with the Linux section format (lines 36, 40). This ensures proper rendering in the documentation component.
| <Code code={`curl --output ${LOCALSTACK_VERSION}-darwin-amd64-onefile.tar.gz \ | |
| --location https://github.com/localstack/localstack-cli/releases/download/${LOCALSTACK_VERSION}/localstack-cli-${LOCALSTACK_VERSION}-darwin-amd64-onefile.tar.gz`} lang="bash" /> | |
| <Code code={`curl --output ${LOCALSTACK_VERSION}-darwin-amd64-onefile.tar.gz \\\n --location https://github.com/localstack/localstack-cli/releases/download/${LOCALSTACK_VERSION}/localstack-cli-${LOCALSTACK_VERSION}-darwin-amd64-onefile.tar.gz`} lang="bash" /> |
add missing backslashes to macos commands