tentative port of finmap.v to HB#84
Merged
CohenCyril merged 4 commits intomath-comp:masterfrom May 22, 2023
Merged
Conversation
CohenCyril
reviewed
Dec 1, 2021
Contributor
|
Here is a rebased branch: https://github.com/proux01/finmap/tree/hierarchy-builder |
affeldt-aist
force-pushed
the
hierarchy-builder
branch
2 times, most recently
from
2424f35 to
2d7b4e9
Compare
Closed
Co-authored-by: Pierre Roux <[email protected]>
Co-authored-by: Pierre Roux <[email protected]>
affeldt-aist
force-pushed
the
hierarchy-builder
branch
from
2d7b4e9 to
c31eefa
Compare
proux01
approved these changes
May 19, 2023
Contributor
proux01
left a comment
proux01
left a comment
There was a problem hiding this comment.
The CI is as green as it can be (the dev Docker images don't exist currently)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that PR 101 has a fixed changelog,
might be worth merging first.
The port of
set.vis recorded in the draft PR #108 .(A version of
set.vis moreover saved in the branchgeneric_sets_mathcomp1for immediate availability.)