GP - Post migration validation feature #29395
Conversation
|
Issue #579005 is not valid. Please make sure you link an issue that exists, is open and is approved. |
Apps/US/HybridGP_US/app/src/Codeunits/GPUSMigrationValidator.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/US/HybridGP_US/app/src/Codeunits/GPUSMigrationValidator.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/US/HybridGP_US/app/src/Codeunits/GPUSMigrationValidator.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/US/HybridGP_US/app/src/Codeunits/GPUSMigrationValidator.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/US/HybridGP_US/app/src/Codeunits/GPUSMigrationValidator.Codeunit.al
Outdated
Show resolved
Hide resolved
| RunVendor1099MigrationValidation(GPCompanyAdditionalSettings); | ||
| end; | ||
|
|
||
| local procedure RunVendor1099MigrationValidation(var GPCompanyAdditionalSettings: Record "GP Company Additional Settings") |
There was a problem hiding this comment.
This test needs to be structured differently.
We must get how far we got during the test, we should update the status every 500-1000 records checked to a table, so we can continue if the test fails. Ideally it should check record by record, not - prepare all data, then check the records.
Without continuation it can easily be interrupted or fail. We could use the same setup record to show the progress - how far did it get.
Apps/W1/HybridBaseDeployment/app/src/pages/CompanyMigrationStatus.Page.al
Outdated
Show resolved
Hide resolved
Apps/W1/HybridBaseDeployment/app/src/pages/CompanyMigrationStatus.Page.al
Outdated
Show resolved
Hide resolved
Apps/W1/HybridBaseDeployment/app/src/pages/IntelligentCloudStatFactbox.Page.al
Show resolved
Hide resolved
|
|
||
| GetUnpostedBatchCounts(); | ||
|
|
||
| RunGLAccountMigrationValidation(GPCompanyAdditionalSettings); |
There was a problem hiding this comment.
Ideally this should not be done in a hardcoded way. We should get a list of records that list the available tests and invoke them via the interface.
There was a problem hiding this comment.
Each validator handles its own group of tests. In my opinion, this simpler approach is easier to understand, implement, and debug.
| LogValidationProgress(ValidationStepStatAccountLbl); | ||
| end; | ||
|
|
||
| local procedure RunBankAccountMigrationValidation(var GPCompanyAdditionalSettings: Record "GP Company Additional Settings") |
There was a problem hiding this comment.
There is too much nesting, these methods should be split in a similar way as IRS validation.
We need to track progress so it can be continued.
…Product Type lookup. Updated Codeunit Id.
4 participants
Fixes #579005