Robustify weak table's handling of indirect recursion in apply_to_all
#52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@microsoft-github-policy-service agree company="Meta" |
bghgary
reviewed
Jan 16, 2026
Contributor
bghgary
left a comment
bghgary
left a comment
There was a problem hiding this comment.
Looks good. Probably should add some tests to make sure the edge cases are covered.
syntheticmagus
changed the title
apply_to_all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework of the
weak_tableto more robustly handle certain edge cases, particularly around "recursive" scenarios which emerge in observer patterns. This particularly impacts scenarios where aweak_tableis backing a signal, and the invocation of that signal results in a change which wants to modify theweak_tablebefore execution of the signal has concluded.