refactor(Popover, Menu): migrate slide animation from CSS to motion component #35665
+542
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertpenner
changed the title
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/Avatar Converged 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Avatar Converged.badgeMask - RTL.normal.chromium.png | 6 | Changed |
| vr-tests-react-components/Avatar Converged.badgeMask.normal.chromium.png | 4 | Changed |
vr-tests-react-components/Charts-DonutChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Charts-DonutChart.Dynamic.default.chromium.png | 5581 | Changed |
vr-tests-react-components/Menu Converged - submenuIndicator slotted content 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Menu Converged - submenuIndicator slotted content.default.submenus open.chromium.png | 607 | Changed |
vr-tests-react-components/Popover Converged 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Popover Converged.when rendering inline, it should not render behind relatively positioned elements.PopoverSurface focused.chromium.png | 93 | Changed |
vr-tests-react-components/Positioning 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Positioning.Positioning end.chromium.png | 615 | Changed |
| vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 14 | Changed |
robertpenner
changed the title
robertpenner
force-pushed
the
refactor/popover-motion-component
branch
from
be02d1f to
1af3aaa
Compare
…tSlideOffsets utility
…ngSlide motion component
…ingSlide motion component
robertpenner
force-pushed
the
refactor/popover-motion-component
branch
from
a0607e8 to
49c8363
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This branch migrates slide animations in Popover and Menu components from CSS-based declarative animations to an imperative approach using the Web Animations API (WAAPI).
Key Changes
New Animation Infrastructure
useSlideAnimationhook in@fluentui/react-positioningfor imperative WAAPI-based slide animationsuseAnimateAtoms,useIsReducedMotion, andAnimationHandletype from@fluentui/react-motionfor public useComponent Migrations
createSlideStylesCSS approach touseSlideAnimationcreateSlideStylesCSS approach touseSlideAnimationBenefits
react-components(~2KB smaller)Cleanup
createSlideStylesCSS codegetSlideOffsetsutilityLet me know if you'd like a walkthrough of how the new
useSlideAnimationhook works or how to use the newly exported animation APIs!