-
Notifications
You must be signed in to change notification settings - Fork 2.9k
chore: remove legacy internal eslint configs #35667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
chore: remove legacy internal eslint configs #35667
Conversation
mainframev
commented
Jan 16, 2026
- Removed legacy internal eslint configs
- Removed a few leftovers with FlatCompat old legacy FUI configs
- Updated README for external eslint-plugin to mention flat configuration example
80d64c4 to
2024ea8
Compare
41b485f to
ad58aa7
Compare
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
ad58aa7 to
d745ebb
Compare
| "**/prismjs": "^1.30.0", | ||
| "**/@tensile-perf/runner/express": "^4.21.2", | ||
| "**/tar-fs": "^2.1.4", | ||
| "jackspeak": "2.1.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
discussed in team channel, this is needed for bypassing issue with yarn.lock:
Problem
When modifying dependencies in this repo, yarn install sometimes consolidates npm alias entries in yarn.lock into a format that breaks --frozen-lockfile validation on CI:
Broken format (consolidated):
"string-width-cjs@npm:string-width@^4.2.0", string-width@^4.1.0, string-width@^4.2.0, string-width@^4.2.3:
Working format (separate):
"string-width-cjs@npm:string-width@^4.2.0":
...
string-width@^4.1.0, string-width@^4.2.0, string-width@^4.2.3:
...
Root Cause
The @isaacs/cliui package (used by jackspeak → glob → jest, mocha, etc.) declares npm aliases (string-width-cjs, strip-ansi-cjs, wrap-ansi-cjs). Yarn 1.x has a bug where --frozen-lockfile fails to validate these consolidated alias entries, even though yarn install without the flag works fine.
Previous Fix
This was already fixed in PR #35611 (commit a33772c), but running yarn install can reconsolidate the entries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we use resolutions for the string-width-cjs/string-width packages affected instead of their dependent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
