Skip to content

Conversation

@mainframev
Copy link
Contributor

  • Removed legacy internal eslint configs
  • Removed a few leftovers with FlatCompat old legacy FUI configs
  • Updated README for external eslint-plugin to mention flat configuration example

@mainframev mainframev self-assigned this Jan 16, 2026
@mainframev mainframev changed the title chore: remove legacy eslint configs chore: remove legacy internal eslint configs Jan 16, 2026
@mainframev mainframev force-pushed the chore/remove-legacy-configs branch from 80d64c4 to 2024ea8 Compare January 16, 2026 10:57
@mainframev mainframev force-pushed the chore/remove-legacy-configs branch 4 times, most recently from 41b485f to ad58aa7 Compare January 22, 2026 09:18
@github-actions
Copy link

github-actions bot commented Jan 22, 2026

📊 Bundle size report

✅ No changes found

@github-actions
Copy link

Pull request demo site: URL

@mainframev mainframev force-pushed the chore/remove-legacy-configs branch from ad58aa7 to d745ebb Compare January 22, 2026 10:17
"**/prismjs": "^1.30.0",
"**/@tensile-perf/runner/express": "^4.21.2",
"**/tar-fs": "^2.1.4",
"jackspeak": "2.1.1",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discussed in team channel, this is needed for bypassing issue with yarn.lock:

Problem

When modifying dependencies in this repo, yarn install sometimes consolidates npm alias entries in yarn.lock into a format that breaks --frozen-lockfile validation on CI:

Broken format (consolidated):

"string-width-cjs@npm:string-width@^4.2.0", string-width@^4.1.0, string-width@^4.2.0, string-width@^4.2.3:

Working format (separate):

"string-width-cjs@npm:string-width@^4.2.0":
...
string-width@^4.1.0, string-width@^4.2.0, string-width@^4.2.3:
...

Root Cause
The @isaacs/cliui package (used by jackspeak → glob → jest, mocha, etc.) declares npm aliases (string-width-cjs, strip-ansi-cjs, wrap-ansi-cjs). Yarn 1.x has a bug where --frozen-lockfile fails to validate these consolidated alias entries, even though yarn install without the flag works fine.

Previous Fix

This was already fixed in PR #35611 (commit a33772c), but running yarn install can reconsolidate the entries.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we use resolutions for the string-width-cjs/string-width packages affected instead of their dependent?

Copy link
Contributor Author

@mainframev mainframev Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, don't think it will work as string-width-cjs is not real package name and just alias. By locking jackspeak we are avoiding @issacs/cliui which brings those aliased packages

image

@mainframev mainframev marked this pull request as ready for review January 22, 2026 10:46
@mainframev mainframev requested review from a team as code owners January 22, 2026 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants