Fix CLOSE_RANGE_CLOEXEC build error on Alpine#873
Merged
Conversation
Co-authored-by: rzhao271 <[email protected]>
Co-authored-by: rzhao271 <[email protected]>
Co-authored-by: rzhao271 <[email protected]>
Copilot
AI
changed the title
[WIP] Fix CLOEXEC issue in Alpine build for node-pty
Define CLOSE_RANGE_CLOEXEC for musl libc compatibility
Jan 13, 2026
Contributor
|
@copilot do not declare a value for the constant. Instead, add to the |
Co-authored-by: rzhao271 <[email protected]>
Contributor
Author
Changed the conditional to check for both |
Copilot
AI
changed the title
Define CLOSE_RANGE_CLOEXEC for musl libc compatibility
Fix CLOSE_RANGE_CLOEXEC build error on Alpine
Jan 13, 2026
mjbvz
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alpine Linux builds fail because musl libc headers don't define
CLOSE_RANGE_CLOEXEC, despite the syscall being available:Changes
SYS_close_rangeandCLOSE_RANGE_CLOEXECbefore using theclose_range()syscall#if defined(SYS_close_range) && defined(CLOSE_RANGE_CLOEXEC)When
CLOSE_RANGE_CLOEXECis not defined (as on Alpine/musl), the code gracefully skips theclose_range()optimization and falls back to the existing loop-based approach for setting close-on-exec flags.Testing
The changes are minimal and surgical, ensuring compatibility with Alpine Linux while maintaining the optimization on systems where it's available.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.