Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 4, 2025

  • Move add_ai_generated, add_feedback, and add_citation methods from ActivityInput base class to MessageActivityInput class
  • Move related helper methods (_ensure_single_root_level_message_entity, _update_entity) to MessageActivityInput
  • Update existing tests in test_activity.py to use MessageActivityInput instead of a concrete test activity
  • Run type checking and tests to verify changes
  • Run code review and security checks

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@heyitsaamir
Copy link
Collaborator

@copilot try again

Copy link
Contributor Author

Copilot AI commented Dec 4, 2025

@copilot try again

Fixed in e8d6495. The tests now properly use MessageActivityInput for the add_ai_generated, add_feedback, and add_citation methods. All 388 tests pass.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • login.microsoftonline.com
    • Triggering command: /home/REDACTED/work/teams.py/teams.py/.venv/bin/pytest pytest packages -v (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants