Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Addresses flakiness in the server-mode TCP startup/abort path (Issue #7398) by tightening cancellation handling around TCP connection establishment and by broadening the set of cancellation-adjacent exceptions treated as expected during shutdown/abort.
Changes:
- Adds a post-
ConnectAsynccancellation check before callingTcpClient.GetStream()to avoid a race where the socket is closed by cancellation. - Consolidates multiple cancellation-related
catchblocks inServerTestHostinto a single filtered catch that also coversInvalidOperationExceptionfromGetStream().
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/Platform/Microsoft.Testing.Platform/ServerMode/JsonRpc/MessageHandlerFactory.cs | Adds a cancellation guard between successful connect and GetStream() to prevent “non-connected sockets” failures. |
| src/Platform/Microsoft.Testing.Platform/Hosts/ServerTestHost.cs | Expands/centralizes cancellation exception handling to treat additional timing-dependent socket exceptions as expected during abort. |
src/Platform/Microsoft.Testing.Platform/Hosts/ServerTestHost.cs
Outdated
Show resolved
Hide resolved
src/Platform/Microsoft.Testing.Platform/ServerMode/JsonRpc/MessageHandlerFactory.cs
Outdated
Show resolved
Hide resolved
src/Platform/Microsoft.Testing.Platform/ServerMode/JsonRpc/MessageHandlerFactory.cs
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #7398