Skip to content

Conversation

@DonJayamanne
Copy link
Contributor

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds additional logging capabilities for kernel messages and improves resource cleanup of kernel execution objects. The changes introduce a new debug setting logKernelMessages that enables detailed kernel message tracing, and ensure proper disposal of NotebookKernelExecution instances when kernels are disposed.

Key changes:

  • New logKernelMessages setting to enable detailed kernel message logging for debugging purposes
  • INotebookKernelExecution interface now extends IDisposable to support proper cleanup
  • Kernel providers now properly dispose execution instances when kernels are disposed
  • Test improvements including better error messages and test naming consistency

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/platform/common/types.ts Added logKernelMessages boolean property to IJupyterSettings interface
src/platform/common/constants.ts Added global logKernelMessages flag and setter function
src/platform/common/configSettings.ts Added logKernelMessages property to JupyterSettings class
src/kernels/types.ts Extended INotebookKernelExecution interface with IDisposable
src/kernels/kernel.ts Added kernel message logging when logKernelMessages is enabled
src/kernels/kernelExecution.ts Changed NotebookKernelExecution to extend DisposableStore for proper cleanup
src/kernels/kernelProvider.base.ts Added execution disposal when kernel is disposed
src/kernels/kernelProvider.node.ts Updated to pass execution instance to disposal handler
src/kernels/kernelProvider.web.ts Updated to pass execution instance to disposal handler
src/kernels/raw/session/rawKernelConnection.node.ts Added subshellId to kernel interrupt request for protocol compliance
src/extension.common.ts Added initialization of logKernelMessages global from settings
src/test/standardTest.node.ts Enabled logKernelMessages setting in test configuration
src/test/common.node.ts Added console logging when capturing screenshots
src/test/datascience/notebook/helper.ts Improved error messages with more context (notebook URI, cell count, content)
src/test/datascience/notebook/executionService.vscode.test.ts Removed unused test stub code
src/test/datascience/widgets/thirdpartyWidgets.vscode.common.test.ts Added test suite suffix to test names for better identification in test output

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants