✨ add support for split utility #380
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianMindee
force-pushed
the
add-v2-split
branch
from
6497dbd to
2179d3a
Compare
sebastianMindee
changed the title
ianardee
requested changes
Jan 29, 2026
| @pytest.fixture(scope="session") | ||
| def split_model_id() -> str: | ||
| """Identifier of the Financial Document model, supplied through an env var.""" | ||
| return os.getenv("MINDEE_V2_SPLIT_UTILITY_MODEL_ID") |
Contributor
There was a problem hiding this comment.
Suggested change
| return os.getenv("MINDEE_V2_SPLIT_UTILITY_MODEL_ID") | |
| return os.getenv("MINDEE_V2_SE_TESTS_SPLIT_MODEL_ID") |
Contributor
There was a problem hiding this comment.
new
enqueue
get_result
enqueue_and_get_result
Remove any notion of slug
deprecated, no changes
enqueue_inference ==> calls enqueue
get_inference ==> calls get_result
enqueue_and_get_inference ==> calls enqueue_and_get_result
Contributor
There was a problem hiding this comment.
separate class for each product
add POST slug
Comment on lines
+120
to
+140
| def _set_inference_params( | ||
| self, data: Dict[str, Union[str, List[str]]], params: InferenceParameters | ||
| ) -> None: | ||
| """ | ||
| Sets the inference-specific parameters. | ||
|
|
||
| :param data: Data dict to fill. | ||
| :param params: Parameters to add. | ||
| """ | ||
| if params.rag is not None: | ||
| data["rag"] = str(params.rag).lower() | ||
| if params.raw_text is not None: | ||
| data["raw_text"] = str(params.raw_text).lower() | ||
| if params.confidence is not None: | ||
| data["confidence"] = str(params.confidence).lower() | ||
| if params.polygon is not None: | ||
| data["polygon"] = str(params.polygon).lower() | ||
| if params.text_context and len(params.text_context): | ||
| data["text_context"] = params.text_context | ||
| if params.data_schema is not None: | ||
| data["data_schema"] = str(params.data_schema) |
Comment on lines
+14
to
+15
| _slug: str = "inferences" | ||
| """Slug of the inference.""" |
Contributor
There was a problem hiding this comment.
move slug to response classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Types of changes