Open
Conversation
When resetting a tinyint value to its default (often 0), it is no longer added to the YAML file. This resulted in the field being ignored on other installs when running a build, and thus not receiving the updated value. Now, all tinyint fields that are NOT explicitly set in the YAML config will be reset to the default value. This ensures that things like enabling/disabling plugins or static templates will be properly applied on remote installations. This fixes modmore#411.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do ?
With this patch, all tinyint fields that are NOT explicitly set in the YAML config will be reset to the default value.
This ensures that things like enabling/disabling plugins or static templates will be properly applied on remote installations.
Why is it needed ?
When resetting a tinyint value to its default (often 0), it is no longer added to the YAML file. This resulted in the field being ignored on other installs when running a build, and thus not receiving the updated value.
Related issue(s)/PR(s)
This fixes #411.