-
Notifications
You must be signed in to change notification settings - Fork 0
chore(backend): implement origin validation for WebSocket connections #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Im-Madhur-Gupta
wants to merge
1
commit into
main
Choose a base branch
from
madhur/enable-cors-protection-on-backend
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
0xflashboy
reviewed
Jan 27, 2026
Comment on lines
+334
to
+355
| match origin { | ||
| Some(o) if o == ALLOWED_ORIGIN => { | ||
| info!("Accepted connection from allowed origin: {}", o); | ||
| Ok(response) | ||
| } | ||
| Some(o) => { | ||
| warn!("Rejected connection from disallowed origin: {}", o); | ||
| let error_response = WsResponse::builder() | ||
| .status(hyper::StatusCode::FORBIDDEN) | ||
| .body(None) | ||
| .unwrap(); | ||
| Err(error_response) | ||
| } | ||
| None => { | ||
| warn!("Rejected connection with no Origin header from {}", addr); | ||
| let error_response = WsResponse::builder() | ||
| .status(hyper::StatusCode::FORBIDDEN) | ||
| .body(None) | ||
| .unwrap(); | ||
| Err(error_response) | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| match origin { | |
| Some(o) if o == ALLOWED_ORIGIN => { | |
| info!("Accepted connection from allowed origin: {}", o); | |
| Ok(response) | |
| } | |
| Some(o) => { | |
| warn!("Rejected connection from disallowed origin: {}", o); | |
| let error_response = WsResponse::builder() | |
| .status(hyper::StatusCode::FORBIDDEN) | |
| .body(None) | |
| .unwrap(); | |
| Err(error_response) | |
| } | |
| None => { | |
| warn!("Rejected connection with no Origin header from {}", addr); | |
| let error_response = WsResponse::builder() | |
| .status(hyper::StatusCode::FORBIDDEN) | |
| .body(None) | |
| .unwrap(); | |
| Err(error_response) | |
| } | |
| } | |
| match origin { | |
| Some(o) => { | |
| if o == ALLOWED_ORIGIN { | |
| info!("Accepted connection from allowed origin: {}", o); | |
| Ok(response) | |
| } else { | |
| warn!("Rejected connection from disallowed origin: {}", o); | |
| let error_response = WsResponse::builder() | |
| .status(hyper::StatusCode::FORBIDDEN) | |
| .body(None) | |
| .unwrap(); | |
| Err(error_response) | |
| } | |
| } | |
| None => { | |
| warn!("Rejected connection with no Origin header from {}", addr); | |
| let error_response = WsResponse::builder() | |
| .status(hyper::StatusCode::FORBIDDEN) | |
| .body(None) | |
| .unwrap(); | |
| Err(error_response) | |
| } | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to be merged ONLY if the security team detects abuse of the backend as it currently does not have CORS protection live, this was done after an agreement that allowing users to connect to backend directly and receive raw event payloads would be a good practice as this is an example app.