adding checks to values to assure that the value is iterable#144
Open
huacchob wants to merge 5 commits intonetworktocode:developfrom
Open
adding checks to values to assure that the value is iterable#144huacchob wants to merge 5 commits intonetworktocode:developfrom
huacchob wants to merge 5 commits intonetworktocode:developfrom
Conversation
huacchob
requested review from
jeffkala,
lvrfrc87,
pszulczewski and
scetron
as code owners
jeffkala
previously approved these changes
Nov 13, 2025
changes/144.fixed
Outdated
| @@ -0,0 +1 @@ | |||
| If the value is a a bool, the function extract_data_from_json will attempt to iterate through the nested values | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| If the value is a a bool, the function extract_data_from_json will attempt to iterate through the nested values | |
| If the value is a boolean, the function extract_data_from_json will attempt to iterate through the nested values |
Author
There was a problem hiding this comment.
6 tasks
jeffkala
requested changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the value is a a bool, the function extract_data_from_json will attempt to iterate through the nested values, this works for any iterable data type, but not for Bool, integers, or floats for example.