Skip to content

perf: Replace getById call with getFistNodeByid #1743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CarlSchwan wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

perf: Replace getById call with getFistNodeByid #1743

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/Service/NotesService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,12 +210,12 @@
* @throws NoteDoesNotExistException
*/
private static function getFileById(string $customExtension, Folder $folder, int $id) : File {
$file = $folder->getById($id);
$file = $folder->getFirstNodeById($id);

Check failure on line 213 in lib/Service/NotesService.php

View workflow job for this annotation

GitHub Actions / static-psalm-analysis dev-stable28

UndefinedInterfaceMethod 

lib/Service/NotesService.php:213:20: UndefinedInterfaceMethod: Method OCP\Files\Folder::getFirstNodeById does not exist (see https://psalm.dev/181)

if (!array_key_exists(0, $file) || !($file[0] instanceof File) || !self::isNote($file[0], $customExtension)) {
if (!($file instanceof File) || !self::isNote($file, $customExtension)) {
throw new NoteDoesNotExistException();
}
return $file[0];
return $file;
}

/**
Expand Down
Loading