Skip to content

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Jan 15, 2026

Since PHP 8.3 the linting command "php -l" can consume multiple files at once.
This drastically speeds up the time necessary for the linting from ~3 minutes
to few seconds.
By also running the linting on multiple cores, the time can be dropped to < 1s

@nickvergessen nickvergessen added this to the Nextcloud 33 milestone Jan 15, 2026
@nickvergessen nickvergessen self-assigned this Jan 15, 2026
@nickvergessen nickvergessen requested a review from a team as a code owner January 15, 2026 11:31
@nickvergessen nickvergessen requested review from Altahrim, ArtificialOwl, come-nc and salmart-dev and removed request for a team January 15, 2026 11:31
@nickvergessen nickvergessen marked this pull request as draft January 15, 2026 12:48
@nickvergessen nickvergessen force-pushed the ci/noid/speedup-lint branch 2 times, most recently from 7f54914 to 9dba927 Compare January 15, 2026 21:59
@nickvergessen nickvergessen changed the title Ci/noid/speedup lint ci(lint): Lint multiple files at once when possible Jan 15, 2026
@nickvergessen nickvergessen added 3. to review Waiting for reviews CI labels Jan 15, 2026
Signed-off-by: Joas Schilling <[email protected]>
Since PHP 8.3 the linting command "php -l" can consume multiple files at once.
This drastically speeds up the time necessary for the linting from ~3 minutes
to few seconds.
By also running the linting on multiple cores, the time can be dropped to < 1s

Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen nickvergessen marked this pull request as ready for review January 19, 2026 15:58
@nickvergessen nickvergessen requested a review from come-nc January 19, 2026 15:58
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏅

@nickvergessen nickvergessen merged commit cf453e5 into master Jan 19, 2026
189 of 201 checks passed
@nickvergessen nickvergessen deleted the ci/noid/speedup-lint branch January 19, 2026 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants