fix: log memory usage for requests based on configured memory limit #57590
+38
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon L. <[email protected]>
szaimen
force-pushed
the
enh/52997/refactor-logging
branch
from
e00ae8f to
287fe12
Compare
szaimen
added
3. to review
szaimen
requested review from
ArtificialOwl,
CarlSchwan,
ChristophWurst,
icewind1991,
juliusknorr,
susnux and
yemkareems
and removed request for
a team
Contributor
Author
|
CI failure is unrelated afaics |
Altahrim
approved these changes
Jan 16, 2026
Altahrim
added
4. to release
|
|
||
| // Check if a memory limit is configured and can be retrieved and determine log level | ||
| if ($memoryLimit !== null && $memoryLimit !== -1) { | ||
| $logLevel = match (true) { |
Member
There was a problem hiding this comment.
Suggested change
| $logLevel = match (true) { | |
| $memoryLimit = min(512_000_000, $memoryLimit); | |
| $logLevel = match (true) { |
I'd prefer this to be capped to 512M. We always want to log things when they are above ~300M, and not skip them because the developer uses 2G locally
Contributor
Author
There was a problem hiding this comment.
This is how this is currently implemented. However we get a lot of complaints by admins and users. See the issue I am trying to fix: #52997
Signed-off-by: Simon L. <[email protected]>
szaimen
force-pushed
the
enh/52997/refactor-logging
branch
from
9d61e68 to
45d3c64
Compare
szaimen
added
3. to review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.