use @aws-cdk/cloudformation-diff for diff generation#33
Open
AndrewChubatiuk wants to merge 3 commits intonicka:masterfrom
Open
use @aws-cdk/cloudformation-diff for diff generation#33AndrewChubatiuk wants to merge 3 commits intonicka:masterfrom
AndrewChubatiuk wants to merge 3 commits intonicka:masterfrom
Conversation
|
This is amazing! |
Author
|
@bm1549 thanks |
|
@AndrewChubatiuk Are you still maintaining your fork? It looks like everything I've been wanting from this repo, but I can't get the diff working. It seems to always show a diff as if no resources have been deployed. |
Author
|
@mrchops1024 yes, still maintaining. I've enabled issues in a fork. Can you post a problem with configuration you're using? |
|
Awesome work @AndrewChubatiuk! |
@AndrewChubatiuk - I raised an issue in your fork but haven't seen any response. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @nicka and @dougmoscrop
Thank you for a project. I've replaced json-diff with aws-cdk/cloudformation-diff to make visualisation more clear and upgraded some packages. I've published it as
serverless-diff-plugin. Please let me know if you are okay with these changescustom.diff.tableWidth(or DIFF_TABLE_WIDTH env variable) parameter to control IAM diff table width (useful for CI log output)custom.diff.excludeskey to exclude some results from diff using jsonpathcustom.diff.reportPathkey for gitlabci tfplan report generation