Skip to content

Conversation

@RafaelGSS
Copy link
Member

As discussed in the release channel, this should prevent people unfamiliar with this state from wrongly promoting a Node.js version.

Refs: nodejs/node#60176

@RafaelGSS RafaelGSS force-pushed the stop-promotion-if-missing-assets branch from 29b5c2d to d366718 Compare October 9, 2025 13:57
@RafaelGSS
Copy link
Member Author

ping @nodejs/build

@aduh95
Copy link
Contributor

aduh95 commented Jan 12, 2026

We should probably give a way to override this if need be, no?

@richardlau
Copy link
Member

We should probably give a way to override this if need be, no?

Presumably that would either be:

  • A y/n question to the releaser, which brings us back to the current situation -- the default of the current set up is to not promote and the releaser has to answer "y" (i.e. affirmative action).
  • Someone in build reverting this change and the releaser trying again. As a Build WG member I'm not overly enthused by that possibility.

I'm on the fence as to whether this is needed, and will go with the Release WG consensus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants