Skip to content

Conversation

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot commented Nov 1, 2025

This is an automated update of icu to 78.2.

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. icu Issues and PRs related to the ICU dependency. test Issues and PRs related to the tests. labels Nov 1, 2025
@nodejs-github-bot
Copy link
Collaborator Author

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Nov 1, 2025
@nodejs-github-bot
Copy link
Collaborator Author

@targos
Copy link
Member

targos commented Nov 1, 2025

/cc @nodejs/i18n-api This output change is weird: https://ci.nodejs.org/job/node-test-commit-linuxone/nodes=rhel9-s390x/52175/testReport/junit/(root)/parallel/test_datetime_change_notify/

  AssertionError [ERR_ASSERTION]: The input did not match the regular expression /Irish Standard Time|Greenwich Mean Time/. Input:

  '11/1/2025, 10:49:12 AM GMT+00:00'

@codecov
Copy link

codecov bot commented Nov 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.52%. Comparing base (842448b) to head (8464435).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #60523      +/-   ##
==========================================
+ Coverage   88.00%   88.52%   +0.52%     
==========================================
  Files         704      704              
  Lines      208739   208739              
  Branches    40196    40285      +89     
==========================================
+ Hits       183706   184796    +1090     
+ Misses      16992    15976    -1016     
+ Partials     8041     7967      -74     

see 102 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@richardlau
Copy link
Member

/cc @nodejs/i18n-api This output change is weird: https://ci.nodejs.org/job/node-test-commit-linuxone/nodes=rhel9-s390x/52175/testReport/junit/(root)/parallel/test_datetime_change_notify/

  AssertionError [ERR_ASSERTION]: The input did not match the regular expression /Irish Standard Time|Greenwich Mean Time/. Input:

  '11/1/2025, 10:49:12 AM GMT+00:00'

FWIW it looks like a change when DST is not in effect (no longer outputs Greenwich Mean time):

> process.env.TZ='Europe/Dublin'
'Europe/Dublin'
> new Date('2025/10/01').toLocaleString('en-US', { timeZoneName: 'long' })
'10/1/2025, 12:00:00 AM Irish Standard Time'
> new Date('2025/11/01').toLocaleString('en-US', { timeZoneName: 'long' })
'11/1/2025, 12:00:00 AM GMT+00:00'
>

@targos
Copy link
Member

targos commented Nov 8, 2025

/cc @srl295

The new output looks more like what we should get with timeZoneName: "longOffset"

@targos
Copy link
Member

targos commented Nov 10, 2025

I pushed an update to the test, but still not convinced that it's an expected change.

@srl295
Copy link
Member

srl295 commented Nov 21, 2025

I pushed an update to the test, but still not convinced that it's an expected change.

Can you file a CLDR issue ?

@targos
Copy link
Member

targos commented Nov 27, 2025

@srl295
Copy link
Member

srl295 commented Nov 29, 2025

CLDR bug: https://unicode-org.atlassian.net/browse/CLDR-19136

it's now an ICU bug, precipitated by a CLDR change.

@targos targos marked this pull request as draft December 14, 2025 09:53
@targos
Copy link
Member

targos commented Dec 14, 2025

https://unicode-org.atlassian.net/browse/ICU-23278

Let's wait for 78.2 or 79.1.

@richardlau
Copy link
Member

https://unicode-org.atlassian.net/browse/ICU-23278

Let's wait for 78.2 or 79.1.

SGTM. FWIW unicode-org/icu#3784 updates icu4c/source/data/misc/metaZones.txt which we don't check into the Node.js source tree so we'd have to regenerate deps/icu-small/source/data/in/icudt78l.dat.bz2 (i.e. we cannot use the floating patch method in https://github.com/nodejs/node/blob/main/doc/contributing/maintaining/maintaining-icu.md#floating-patches-to-icu).

Having said that, we do regenerate the dat file to pick up timezone updates (there's one coming (2025c) from unicode-org/icu-data#46).

@nodejs-github-bot nodejs-github-bot changed the title deps: update icu to 78.1 deps: update icu to 78.2 Jan 9, 2026
@nodejs-github-bot nodejs-github-bot force-pushed the actions/tools-update-icu branch from 71bf557 to 9fad880 Compare January 9, 2026 05:48
@targos targos marked this pull request as ready for review January 9, 2026 06:00
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 10, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 10, 2026
@nodejs-github-bot
Copy link
Collaborator Author

Copy link
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Thanks @targos for the bug report that was part of precipitating the CLDR and ICU dot-release!

@srl295
Copy link
Member

srl295 commented Jan 10, 2026

I can't read the AIX failing error, can anyone grant access to @srl295 (jenkins)

@nodejs-github-bot
Copy link
Collaborator Author

@aduh95 aduh95 force-pushed the actions/tools-update-icu branch from 9a5767f to 8464435 Compare January 11, 2026 07:19
@nodejs-github-bot
Copy link
Collaborator Author

@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jan 11, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 11, 2026
@nodejs-github-bot nodejs-github-bot merged commit 1bd7f62 into main Jan 11, 2026
100 of 101 checks passed
@nodejs-github-bot
Copy link
Collaborator Author

Landed in 1bd7f62

@nodejs-github-bot nodejs-github-bot deleted the actions/tools-update-icu branch January 11, 2026 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dependencies Pull requests that update a dependency file. icu Issues and PRs related to the ICU dependency. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants