tools: test building with --experimental-quic #61446
Conversation
Move node:quic behind a compile-time flag, disabled by default. Use --experimental-quic at configure time to enable. - Add --experimental-quic flag to configure.py - Add node_use_quic variable and HAVE_QUIC define - Make QUIC sources conditional in node.gyp - Move ngtcp2/nghttp3 deps under QUIC condition in node.gypi - Update C++ guards to check HAVE_QUIC - Update process.features.quic to check node_use_quic
aduh95
added
dont-land-on-v20.x
|
Review requested:
|
nodejs-github-bot
added
lib / src
AFAIK the quic stuff has been mostly labelled |
|
I was happy to see #61444 because QUIC has become a burden to maintain because of the lack of proper maintainers (at least to me because I had to fix things in it while I don't care about it). This will make it worse as we will only see issues (and have to fix them) in GitHub CI. |
|
My opinion is that while a feature is so much experimental (or unmaintained) that it has to be behind a build flag, we shouldn't put the burden of keeping it working to every contributor. |
|
I wouldn't mind having the experimental removed from CI if we need to break it, it seems useful to be aware of when that happens though. In any case, I would still like to land the Nix changes marking QUIC deps as disabled by default. |
6 participants
c1277d6 is from #61444, which should land first. Taking it to a separate PR as we can't backport Nix changes further than v25.x.