Skip to content

[v20.x] doc: supported toolchain with Visual Studio 2019 & 2022 only #61450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
MikeMcC399 wants to merge 1 commit into
base: v20.x-staging
Choose a base branch
from
Open

[v20.x] doc: supported toolchain with Visual Studio 2019 & 2022 only #61450

MikeMcC399 wants to merge 1 commit into from
+6 −6

Conversation

@MikeMcC399
Copy link
Contributor

@MikeMcC399 MikeMcC399 commented Jan 20, 2026 •
edited
Loading

Refs: #60869
Refs: #61449

Situation

The Supported toolchains section for v20.x lists Visual Studio >= 2019 with the Windows 10 SDK on a 64-bit host.

By implication, this includes also the latest release of Microsoft Visual Studio which is Visual Studio 2026.

.\vcbuild fails to run in the v20.x branch on Windows 11 25H2 in a PowerShell terminal with the Windows Prerequisites installed, and only using Visual Studio Build Tools 2026.

Failure log

 .\vcbuild
Looking for Python
Python found in C:\Users\mikem\AppData\Local\Microsoft\WindowsApps\\python.exe
Python 3.14.2
Looking for NASM
Looking for Visual Studio 2022
Looking for Visual Studio 2019
Failed to find a suitable Visual Studio installation.
Try to run in a "Developer Command Prompt" or consult
https://github.com/nodejs/node/blob/HEAD/BUILDING.md#windows

Change

In BUILDING.md

  • restrict to Visual Studio 2019 & 2022 for toolchain
  • tie reference to "Visual Studio 17.6.0 or newer" explicitly to Visual Studio 2022

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 20, 2026

Review requested:

  • @nodejs/build
  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. labels Jan 20, 2026
@MikeMcC399 MikeMcC399 marked this pull request as ready for review January 20, 2026 12:39
@MikeMcC399 MikeMcC399 mentioned this pull request Jan 20, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sxa sxa sxa approved these changes

@StefanStojanovic StefanStojanovic StefanStojanovic approved these changes

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MikeMcC399 @nodejs-github-bot @sxa @StefanStojanovic