Open
Conversation
gerardsn
reviewed
Jul 28, 2025
Member
gerardsn
left a comment
There was a problem hiding this comment.
I like the idea of adding the tools to the dependencies since it makes managing tool versions a bit easier and more transparent to users. However, this adds ~650 lines to go.mod/go.sum and nearly doubles their sizes. One of the reasons oapi-codegen was split into a runtime and a generator repo was to remove this dependency bloat.
I consider the current list of dependencies (just go.mod) sort of manageable by hand in terms of deciding when/how to make changes. After this change the list will be too long for me to keep track of what everything is and what it is used for. But that is just an opinion and others may disagree / not care about this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows dependabot to track updates to tool packages as well.