Skip to content

#3986: Pass correct wallet DID in OpenID4VCI proofs#3987

Merged
reinkrul merged 2 commits intomasterfrom
iss3986-pass-correct-walletdid
Feb 5, 2026
Merged

#3986: Pass correct wallet DID in OpenID4VCI proofs#3987
reinkrul merged 2 commits intomasterfrom
iss3986-pass-correct-walletdid

Conversation

@reinkrul
Copy link
Member

@reinkrul reinkrul commented Feb 5, 2026

Fixes #3986

@qltysh
Copy link

qltysh bot commented Feb 5, 2026

2 new issues

Tool Category Rule Count
qlty Structure Function with many returns (count = 8): handleOpenID4VCICallback 1
ripgrep Lint // TODO: check that issued credential is bound to DID that requested it (OwnDID)??? 1

@qltysh
Copy link

qltysh bot commented Feb 5, 2026

Qlty

Coverage Impact

⬆️ Merging this pull request will increase total coverage on master by 0.03%.

Modified Files with Diff Coverage (1)

RatingFile% DiffUncovered Line #s
Coverage rating: B Coverage rating: B
auth/api/iam/openid4vci.go75.0%141
Total75.0%
🤖 Increase coverage with AI coding...

In the `iss3986-pass-correct-walletdid` branch, add test coverage for this new code:

- `auth/api/iam/openid4vci.go` -- Line 141

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@rolandgroen rolandgroen self-requested a review February 5, 2026 10:03
Copy link
Contributor

@rolandgroen rolandgroen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor remarks, pls review.

@reinkrul reinkrul merged commit 08fe526 into master Feb 5, 2026
9 checks passed
@reinkrul reinkrul deleted the iss3986-pass-correct-walletdid branch February 5, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OpenID4VCI: proof for calling Token Endpoint uses random DID instead of specified wallet_did

3 participants