feat: format known addresses #616
Conversation
✅ Deploy Preview for oasisprotocol-cli canceled.
|
uniyalabhishek
force-pushed
the
uniyalabhishek/feature/format-known-addresses-131
branch
from
0068b35 to
95ace6e
Compare
|
This would be nice addition. @uniyalabhishek can you rebase? @matevz can you review please? |
@ptrus sorry, this PR is not fully ready for review now (also oasisprotocol/oasis-sdk#2335). there have been higher-priority tasks and missed completing this. will prioritise it this week. |
uniyalabhishek
force-pushed
the
uniyalabhishek/feature/format-known-addresses-131
branch
from
95ace6e to
ee0dbb3
Compare
|
FYI I'll be refactoring |
uniyalabhishek
force-pushed
the
uniyalabhishek/feature/format-known-addresses-131
branch
from
ee0dbb3 to
2bcd0ad
Compare
fix(account show): propagate derived eth address
uniyalabhishek
force-pushed
the
uniyalabhishek/feature/format-known-addresses-131
branch
from
c451ac0 to
a2b7ccc
Compare
uniyalabhishek
requested review from
matevz,
peternose and
ptrus
and removed request for
matevz and
peternose
matevz
left a comment
matevz
left a comment
There was a problem hiding this comment.
First pass. IMO we should simplify more.
| // GenAccountNamesForNetwork generates a map of all addresses -> account name for pretty printing, | ||
| // including network-specific entries (paratimes, ROFL providers) when a network is provided. | ||
| // Priority order (later entries overwrite earlier): test accounts < network entries < addressbook < wallet. | ||
| func GenAccountNamesForNetwork(net *configSdk.Network) types.AccountNames { |
There was a problem hiding this comment.
I'd simplify by removing the network parameter and just dump all paratime info from all the networks stored in the config.
| func GenAddressFormatContextForNetwork(net *configSdk.Network) AddressFormatContext { | ||
| return AddressFormatContext{ | ||
| Names: GenAccountNamesForNetwork(net), | ||
| Eth: GenAccountEthMapForNetwork(net), |
There was a problem hiding this comment.
Do we need to separate between the eth and non-eth accounts?
This makes “known address” rendering consistent across CLI text output, and prefers Ethereum hex in parentheses when available (while still showing both addresses where required).
common.PrettyAddress{With,ResolvedAddressWith}+ precomputed formatting context (wallet/addressbook/test + network-derived entries likeparatime:*and ROFL defaults).name (address)instead of raw bech32.eth_addressmetadata on create/import/load (best-effort) so ETH can be displayed without unlocking later.oasis wallet showandoasis account showdisplay both Ethereum + native addresses, elsewhere prefer Ethereum in parentheses when available.go test ./...passing with localgo.work.Dependency: This PR depends on oasis-sdk PR oasisprotocol/oasis-sdk#2335 being merged and a new
github.com/oasisprotocol/oasis-sdk/client-sdk/gorelease being published, after that we’ll bump the SDK version.