feat(instrumentation-graphql): add parent name in attributes of resolver span #3287
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
I am trying to derive performance metrics from GraphQL traces.
Currently, I cannot consistently measure the performance of a specific, logical resolver, identified by the combination of its parent type name and field name.
While the existing
graphql.field.pathattribute is available, it is query-path dependent. Consider this simplified schema and two queries hitting the samenameresolver:Both queries execute the same
Account.nameresolver, but the existinggraphql.field.pathdiffers. This makes it impossible to aggregate all performance data forAccount.nameusing the existing attributes.Short description of the changes
This PR adds the parent type name to a new attribute on resolver spans
graphql.parent.nameto theAttributeNamesenum.info.parentType.namein this new attribute.