Write scientific defaults upon close (Iteration::close or Series::close) #1834
+1,245
−422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+281
to
+284
| // for (size_t i = 0; i < udims.size(); ++i) | ||
| // { | ||
| // res[7 * i] = 1; | ||
| // } |
Check notice
Code scanning / CodeQL
Commented-out code Note
Comment on lines
+698
to
+701
| // TODO: unitSI | ||
| // REQUIRE(r["x"].numAttributes() == 0); | ||
| // REQUIRE(r["y"].numAttributes() == 0); | ||
| // REQUIRE(r["z"].numAttributes() == 0); |
Check notice
Code scanning / CodeQL
Commented-out code Note test
Contributor
Author
|
TODO: Move this check into finalize, maybe only print a warning throw std::runtime_error(
"A Record can not be written without any contained "
"RecordComponents: " +
name); |
Member
|
@franzpoeschel is this for 0.18.0? :) |
Contributor
Author
Yup, this is still under development |
Moved to finalize(), degraded to warning
franzpoeschel
force-pushed
the
defaults-upon-close
branch
from
0f1d020 to
2115ede
Compare
prep for reading
franzpoeschel
force-pushed
the
defaults-upon-close
branch
from
941b3fd to
03b283b
Compare
Comment on lines
367
to
423
| switch (wor) | ||
| { | ||
| case WriteOrRead::Write: | ||
| break; | ||
| case WriteOrRead::Read: { | ||
| Parameter<Operation::READ_ATT> aRead; | ||
| aRead.name = this->attrName; | ||
| auto IOHandler = this->child.IOHandler(); | ||
| IOHandler->enqueue(IOTask(&this->child, aRead)); | ||
| try | ||
| { | ||
| IOHandler->flush(defaultFlushParams); | ||
| } | ||
| catch (error::ReadError const &e) | ||
| { | ||
| std::cerr << "Could not read expected attribute '" | ||
| << this->attrName << "' in '" | ||
| << this->child.myPath().openPMDPath() | ||
| << ". Will initialize it with a default value. " | ||
| "Original error: " | ||
| << e.what() << std::endl; | ||
| this->set(this->get()); | ||
| return; | ||
| } | ||
|
|
||
| Attribute attribute( | ||
| Attribute::from_any, std::move(*aRead.m_resource)); | ||
| auto dt = attribute.dtype; | ||
| AttributeReadResult readResult = | ||
| attributeReader(this->child, attribute); | ||
| std::visit( | ||
| auxiliary::overloaded{ | ||
| [&](attribute_read_result::TypeUnmatched) { | ||
| std::cerr << "Unexpected type '" << dt | ||
| << "' for attribute '" << this->attrName | ||
| << "' in '" | ||
| << this->child.myPath().openPMDPath() | ||
| << "' with value '"; | ||
| write_to_stderr(attribute) | ||
| << "'. Expected one of [UNIMPLEMENTED: PRINT TYPES " | ||
| "HERE] or convertible to such a type." | ||
| << std::endl; | ||
| }, | ||
| [&](error::ReadError const &err) { | ||
| std::cerr << "Unexpected error while trying to read " | ||
| "attribute '" | ||
| << this->attrName << "' in '" | ||
| << this->child.myPath().openPMDPath() | ||
| << "'' with value '"; | ||
| write_to_stderr(attribute) | ||
| << "': " << err.what() << std::endl; | ||
| }, | ||
| [](attribute_read_result::Success) { /* no-op */ }}, | ||
| std::move(readResult)); | ||
| } | ||
| break; | ||
| } |
Check notice
Code scanning / CodeQL
Long switch case Note
| template <typename ExpectedAttributeType, typename... Args> | ||
| [[nodiscard]] auto | ||
| ConfigAttributeWithSetter<RecordType, GetDefaultValue, SetDefaultValue>:: | ||
| withReader(Args &&...args) && |
Check notice
Code scanning / CodeQL
Unused static variable Note
| template <typename ExpectedAttributeType, typename... Args> | ||
| [[nodiscard]] auto | ||
| ConfigAttributeWithSetter<RecordType, GetDefaultValue, SetDefaultValue>:: | ||
| withReader(Args &&...args) && |
Check notice
Code scanning / CodeQL
Unused local variable Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1439
This PR focuses on Iteration-level attributes (including attributes included below Iteration level)
Needed for introducing a synchronous mode
TODO:
finalize()method publically, so users can request openPMD to set defaults now