Disable insecure collaboration app when INSECURE MODE is disabled#171
Open
pierrecnalb wants to merge 1 commit intoopencloud-eu:mainfrom
Open
Disable insecure collaboration app when INSECURE MODE is disabled#171pierrecnalb wants to merge 1 commit intoopencloud-eu:mainfrom
pierrecnalb wants to merge 1 commit intoopencloud-eu:mainfrom
Conversation
In the [documentation](https://docs.opencloud.eu/docs/admin/getting-started/container/docker-compose/docker-compose-base#disable-insecure-mode) the INSECURE_MODE is simply disabled and not set to false. This makes collabora using insecure connection, even when behind an external proxy.
Contributor
|
Honestly, that needs to be tested. A lot of services in the opencloud internal service mesh are using TLS with a self signed certificate. That is what all that is about. We want to use TLS internally too, but it is not so critical to have a self signed certificate. The "outside world" gets a valid certificate via the reverse proxy. Doing this also internally would make maintenance more complicated because we would need a offlie Root CA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the opencloud documentation for both docker compose, and external-proxy the INSECURE_MODE is simply disabled and not set to false.
This makes both
COLLABORATION_APP_INSECUREandCOLLABORATION_CS3API_DATAGATEWAY_INSECUREset totrue. I don't know enough about wopiserver and collabora to know if this is legitimate or not, but it feels wrong to me to use insecure mode for production servers...If that's legitimate, maybe adding a comment would help understanding why insecure is fine.