refactor: move getIndicators to a composable#1904
Merged
JammingBen merged 1 commit intomainfrom Feb 4, 2026
Merged
Conversation
This way we don't need to pass all the data to the method that can easily be retrieves when using other composables.
kulmann
approved these changes
Feb 4, 2026
| SpaceResource | ||
| } from '@opencloud-eu/web-client' | ||
| import { useInterceptModifierClick } from '../keyboardActions' | ||
| import { useResourcesStore, useSideBar, useUserStore } from '../piniaStores' |
Member
There was a problem hiding this comment.
didn't notice it before, but why is useSideBar not named useSideBarStore? 🤔
Member
Author
There was a problem hiding this comment.
Mainly because of compatibility reasons (would be breaking otherwise). But I also find that ...Store in this context is not really needed. We also don't have it for e.g. useModals and useMessages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way we don't need to pass all the data to
getIndicators(). Also, it allows us to use the sidebar store actions instead of using the now deprecated events.The old
getIndicatorsmethod has been deprecated for compatibility reasons. It now calls the new composable internally.Follow-up for #1897