-
Notifications
You must be signed in to change notification settings - Fork 8
Remove undefined terms in parameterGroup examples #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hi @chris-little, thanks for doing this. Having thought about it, I'm wondering if we should just remove the section about statistical measures altogether for now. There's a lot of stuff that would need defining, even in the new simplified version. How about simply including some placeholder text, e.g. "ParameterGroups can also be used to gather related statistical quantities, but this will be defined in a future version of the spec"? |
|
This looks OK as far as I can tell but would benefit from a review from someone who's more familiar with how to insert new vocabularies via the JSON-LD context - perhaps @KathiSchleidt? |
link to archived version of UncertML website (closed in 2016)
Reliable reference for statistical Measures found
|
I'm fine with the hack of referencing eurostat glossary terms, but don't understand why you removed the |
|
On
I left various comments in the file |
|
@KathiSchleidt > I'm fine with the hack of referencing eurostat glossary terms, but don't understand why you removed the The PR was to remove undefined terms in response to your Issue #194 . It is only an example. It is not normative. Do you have a reliable source definition of |
Corrected my mental glitch, thank you @kschleidt
improved English
Simplified example
|
@jonblower @letmaik This is a tidy up of examples so that they work, and point to resolvable meaningful resources. And fix my mental glitch. |
|
@jonblower Have you time for a review? @KathiSchleidt has corrected the JSON-LD syntax. Parameter Group examples simplified and fully resolvable. |
Added missing reference to Eurostat in JSONLD section example
|
@chris-little just wanted to draw attention to my review comment. Do we need the extra example (lines 978 and onwards?) This seems to mainly be a copy of the same example from earlier in the spec. (Also it would be good to tidy up the formatting/indentation.) |
|
@ghobona @gbuehler Have we just found a Metanorma bug? I have no idea what |
|
@chris-little The standard / document.adoc builds fine for me. What specifically are you seeing? As for LutaML, see: https://www.metanorma.org/author/topics/automation/lutaml_uml/ |
Removed undefined terms
narrowerThan,statisticalMeasureandstatisticalPeriodfrom the Parameter Group examples. Add another example to the JSON-LD section.