Remove init_template_fix patch dependency for make check#324
Merged
mason-sharp merged 1 commit intomainfrom Feb 4, 2026
Merged
Remove init_template_fix patch dependency for make check#324mason-sharp merged 1 commit intomainfrom
mason-sharp merged 1 commit intomainfrom
Conversation
Override with_temp_install in Makefile to allow spock tests to run without requiring the pg*-090-init_template_fix.diff patch to be applied to PostgreSQL source. Changes: - Remove INITDB_TEMPLATE from with_temp_install (not needed for extension tests that use installed PostgreSQL) - Use actual bindir/libdir instead of tmp_install paths - Delete pg17-090-init_template_fix.diff and pg18-090-init_template_fix.diff Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
|
Looks good |
danolivo
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Override with_temp_install in Makefile to allow spock tests to run without requiring the pg*-090-init_template_fix.diff patch to be applied to PostgreSQL source.
Changes: