Open
Conversation
22aronl
force-pushed
the
usb-hardware-fixes-1.3
branch
from
6a61a35 to
a3561a5
Compare
hexatedjuice
approved these changes
May 2, 2025
ameyer1024
reviewed
May 2, 2025
Comment on lines
+243
to
+249
| impl<const N: usize, T> Clone for Sender<N, T> { | ||
| fn clone(&self) -> Self { | ||
| Self { | ||
| inner: self.inner.clone(), | ||
| } | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
This is unsound -- the channel is internally SPSC, so making additional Senders or Receivers will corrupt data. The simplest fix is to use a lock (probably a binary semaphore, since IIRC we don't have an async/await lock api) to make a MPMC version (as a different type? so we don't get perf overhead on the SPSC use cases)
ameyer1024
reviewed
May 2, 2025
ameyer1024
reviewed
May 2, 2025
ameyer1024
force-pushed
the
usb-hardware-fixes-1.3
branch
from
6af2172 to
8b50a42
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Networking Fixes(hexated) & USB HS fixes (22aaronl)