remove duplicate error code check and add some public method#22
Open
imtbkcat wants to merge 12 commits intopingcap:masterfrom
Open
remove duplicate error code check and add some public method#22imtbkcat wants to merge 12 commits intopingcap:masterfrom
imtbkcat wants to merge 12 commits intopingcap:masterfrom
Conversation
overvenus
reviewed
Jul 31, 2020
terror_registry.go
Outdated
Comment on lines
35
to
46
| // CodeExecResultIsEmpty indicates execution result is empty. | ||
| CodeExecResultIsEmpty ErrCode = 3 | ||
|
|
||
| // Expression error codes. | ||
|
|
||
| // CodeMissConnectionID indicates connection id is missing. | ||
| CodeMissConnectionID ErrCode = 1 | ||
|
|
||
| // Special error codes. | ||
|
|
||
| // CodeResultUndetermined indicates the sql execution result is undetermined. | ||
| CodeResultUndetermined ErrCode = 2 |
Member
There was a problem hiding this comment.
Please do not add TiDB specific error to this lib. How about defining these code in TiDB？
|
LGTM |
Author
|
PTAL @overvenus |
added 3 commits
August 3, 2020 14:06
Member
|
Actually, it looks wired to import log related dependencies in common error repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TiDB use same error code to represent a class of code, like
8200contain a series of error related to unsupported ddl. When using this terror lib, TiDB will panic. So, I remove this check.