Fix draw rectangle in BufferedDrawNode not being aligned with framebuffer rectangle #6670
+129
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Maybe I'm just unsure of what I'm looking at, but it's still looking weird at low speed/0.25 scale (on my MBP as this is resolution dependent). Before: 2025-11-17.13-56-52.mp4After: 2025-11-17.13-57-34.mp4The before one is behaving more like what I'd expect here where the box is centred but not aligned to the pixel grid, same with the diagonal lines being more stable. |
Contributor
Author
I'm honestly not 100% sure what it should look like at lower framebuffer scale either. renderer.PushOrtho(screenSpaceDrawRectangle);
var topLeft = new Vector4(DrawRectangle.Left, DrawRectangle.Top, 0, 1) * renderer.ProjectionMatrix;
var bottomRight = new Vector4(DrawRectangle.Right, DrawRectangle.Bottom, 0, 1) * renderer.ProjectionMatrix;
Logger.Log($"{topLeft.Xy}, {bottomRight.Xy}"); |
Contributor
Author
|
Right... Looks like while the draw rect is rounded to whole pixels now, the drawbles are still drawn at their original coords which just moved the misaligned somewhere else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BufferedDrawNode rounds the frameBufferSize to int, but uses the original draw rectangle to do futher rendering with. This caused the content being misaligned with the pixel grid when the containers bounds weren't integer coordinates.
With
pixelSnapping: falsethis would cause the content to become blurry due to the framebuffer texture being drawn with linear interpolation. A common workaround in osu for this is to use aFrameBufferScalegreater than 1.With
pixelSnapping: truethis would instead result in the content randomly shifting around when the container changes position/size.With this change it will first compute the frameBuffer size and base the draw rectangle off of that. At frameBufferScale=1 there should be no discernible difference between having the content in/outside a BufferedContainer, with both pixelSnapping being on or off.
Before
2025-11-17.05-35-06.mp4
After
2025-11-17.05-35-39.mp4
Was briefly discussed on discord