Skip to content

Conversation

@jaydeluca
Copy link
Collaborator

Alternate approach to #1728

I still also have scrape time validation occurring along with registration time, but we can remove that if we think the registration time validation is sufficient protection.

@jaydeluca jaydeluca force-pushed the duplicate-names-registration-validation branch from 7203084 to 2359244 Compare January 24, 2026 16:10
Signed-off-by: Jay DeLuca <jaydeluca4@gmail.com>
Signed-off-by: Jay DeLuca <jaydeluca4@gmail.com>
Signed-off-by: Jay DeLuca <jaydeluca4@gmail.com>
Signed-off-by: Jay DeLuca <jaydeluca4@gmail.com>
Signed-off-by: Jay DeLuca <jaydeluca4@gmail.com>
Signed-off-by: Jay DeLuca <jaydeluca4@gmail.com>
@jaydeluca jaydeluca force-pushed the duplicate-names-registration-validation branch from 2359244 to 9289e4a Compare January 24, 2026 16:10
Signed-off-by: Jay DeLuca <jaydeluca4@gmail.com>
@zeitlinger
Copy link
Member

I still also have scrape time validation occurring along with registration time, but we can remove that if we think the registration time validation is sufficient protection.

I would opt for registration only.

What does that mean for clients that only work on snapshots like the OTel SDK?

https://github.com/open-telemetry/opentelemetry-java/blob/da310cc1fcd06e606426649f6c8db96958d9bb12/exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/PrometheusMetricReader.java#L104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants