Added Redis SCAN functions #3
Open
Woody88 wants to merge 3 commits intopurescript-node-contrib:masterfrom
Open
Added Redis SCAN functions #3Woody88 wants to merge 3 commits intopurescript-node-contrib:masterfrom
Woody88 wants to merge 3 commits intopurescript-node-contrib:masterfrom
Conversation
Member
|
@Woody88 I'm not sure if you have seen these minor points from my side. If you don't have time to incorporate these changes I would fix them myself - no problem :-) |
Author
paluh
reviewed
May 14, 2020
| @@ -33,6 +35,7 @@ module Database.Redis | |||
| , rpop | |||
| , rpush | |||
Member
There was a problem hiding this comment.
c is actually before e in the alphabet :-P
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added these functions https://github.com/luin/ioredis#streamify-scanning or https://redis.io/commands/scan.
This allows one to scan the keys that was created for a specific data structure. I've also added a comment in the FFI, it would be nice to hear your thoughts about it.
I've also implemented tests for each scan function.