Open
Conversation
jaehyeonpy
commented
Aug 31, 2023
jaehyeonpy
commented
- PEP 484 참고하여 작업하였습니다.
- docstrings에 타입 힌트 내용이 포함되어 있습니다.
- 모든 테스트 통과했습니다.
- Github actions 상에서도 잘 동작합니다.
…ython-mysql-replication into feature/modify-docstrings
…ty in some events
dongwook-chan
approved these changes
Sep 1, 2023
dongwook-chan
left a comment
dongwook-chan
left a comment
There was a problem hiding this comment.
꼼꼼하게 typing 잘 적용해주신 것 같습니다!! 고생 많으셨습니다~~~ 👍🏻👍🏻👍🏻👍🏻
| import struct | ||
| import datetime | ||
| import pymysql | ||
| from pymysql.protocol import MysqlPacket |
| Attributes: | ||
| position: Position inside next binlog | ||
| next_binlog: Name of next binlog file | ||
| For more information: `[see details] <https://dev.mysql.com/doc/dev/mysql-server/latest/classbinary__log_1_1Rotate__event.html>`_. |
There was a problem hiding this comment.
어디는 see details, 어디는 see {클래스명}이네요.
링크를 좀 더 명확히 설명한다는 취지에 공감이 되어서 후자가 좋아보이네요.
이미 머지되어서 변경해주실 필요는 없고 피드백만 드려요~
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.