feature: add type hint to event.py, row_event.py, binlogfilereader.py#87
Open
feature: add type hint to event.py, row_event.py, binlogfilereader.py#87
Conversation
Co-authored-by: suhwan-cheon <soo7652@naver.com> Co-authored-by: ebang091 <dskhe8@gmail.com> Co-authored-by: yangbaechu <abab_1212@naver.com> Co-authored-by: jaehyeonpy <jaehyeonpy@gmail.com>
Author
|
conflict 해결이 잘 안되어있던 부분 재 수정해서 올리겠습니다! |
Author
|
변경사항 : 이 부분의 두 줄코드를 한줄로 만들었던 코드가 잘 작동하지 않아서 다시 분리해서 변경해두었습니다. (489) |
Co-authored-by: suhwan-cheon <soo7652@naver.com> Co-authored-by: ebang091 <dskhe8@gmail.com> Co-authored-by: yangbaechu <abab_1212@naver.com> Co-authored-by: jaehyeonpy <jaehyeonpy@gmail.com>
ebang091
force-pushed
the
feature/typing-event,binlogfilereader
branch
from
0778fba to
5639d30
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
##요약
했던 과정 모두 squash 하여 하나의 commit으로 만들었습니다.
내용
event.py
rows_event.py
binlogfilereader.py
수정
참고
import import pymysql 도 다시 확인해보니 밑줄이 그어져 있는데 해결방안과 이유를 알아보아야 할 것 같습니다.