gh-143135: Fix sys.flags.inspect when PYTHONINSPECT=0 #143136
Merged
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Misc/NEWS.d/next/Core_and_Builtins/2025-12-24-11-39-59.gh-issue-143135.3d5ovx.rst
Outdated
Show resolved
Hide resolved
Misc/NEWS.d/next/Core_and_Builtins/2025-12-24-11-39-59.gh-issue-143135.3d5ovx.rst
Outdated
Show resolved
Hide resolved
serhiy-storchaka
added
needs backport to 3.13
vstinner
reviewed
Dec 24, 2025
Misc/NEWS.d/next/Core_and_Builtins/2025-12-24-11-39-59.gh-issue-143135.3d5ovx.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Victor Stinner <[email protected]>
serhiy-storchaka
approved these changes
Dec 24, 2025
Member
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
LGTM. 👍
Sorry for been so picky.
Misc/NEWS.d/next/Core_and_Builtins/2025-12-24-11-39-59.gh-issue-143135.3d5ovx.rst
Outdated
Show resolved
Hide resolved
Member
Author
No worries, I was busy and the commits were not as good as they should be. Merry Christmas! |
|
Thanks @StanFromIreland for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 24, 2025
…-143136) (cherry picked from commit 3509fa5) Co-authored-by: Stan Ulbrych <[email protected]>
|
Sorry, @StanFromIreland and @serhiy-storchaka, I could not cleanly backport this to |
|
GH-143153 is a backport of this pull request to the 3.14 branch. |
serhiy-storchaka
changed the title
PYTHONINSPECT check consistent
serhiy-storchaka
pushed a commit
that referenced
this pull request
Dec 24, 2025
…) (GH-143153) (cherry picked from commit 3509fa5) Co-authored-by: Stan Ulbrych <[email protected]>
StanFromIreland
added a commit
to StanFromIreland/cpython
that referenced
this pull request
Dec 25, 2025
…ythonGH-143136) (cherry picked from commit 3509fa5) Co-authored-by: Stan Ulbrych <[email protected]>
|
GH-143168 is a backport of this pull request to the 3.13 branch. |
serhiy-storchaka
pushed a commit
that referenced
this pull request
Dec 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PYTHONINSPECTis checked inconsistently #143135